utils.test.js ➔ ... ➔ ??? - Code Metrics - Inspection of "Feature/paginated charts" - shlinkio/shlink-web-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#124)

by Alejandro

created 2019-03-16 08:02 UTC

utils.test.js ➔ ... ➔ ??? A

↳ Parent: utils.test.js ➔ ???

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	1
eloc	11
c	4
b	0
f	0
nc	1
nop	0
dl	0
loc	17
rs	9.85

import * as sinon from 'sinon';
import L from 'leaflet';
import marker2x from 'leaflet/dist/images/marker-icon-2x.png';
import marker from 'leaflet/dist/images/marker-icon.png';
import markerShadow from 'leaflet/dist/images/marker-shadow.png';
import {
  stateFlagTimeout as stateFlagTimeoutFactory,

  determineOrderDir,
  fixLeafletIcons,
  rangeOf,
  roundTen,
} from '../../src/utils/utils';

describe('utils', () => {
  describe('stateFlagTimeout', () => {
    it('sets state and initializes timeout with provided delay', () => {
      const setTimeout = sinon.fake((callback) => callback());
      const setState = sinon.spy();
      const stateFlagTimeout = stateFlagTimeoutFactory(setTimeout);
      const delay = 5000;
      const expectedSetStateCalls = 2;

      stateFlagTimeout(setState, 'foo', false, delay);

      expect(setState.callCount).toEqual(expectedSetStateCalls);
      expect(setState.getCall(0).args).toEqual([{ foo: false }]);
      expect(setState.getCall(1).args).toEqual([{ foo: true }]);
      expect(setTimeout.callCount).toEqual(1);
      expect(setTimeout.getCall(0).args[1]).toEqual(delay);
    });
  });

  describe('determineOrderDir', () => {
    it('returns ASC when current order field and selected field are different', () => {
      expect(determineOrderDir('foo', 'bar')).toEqual('ASC');
      expect(determineOrderDir('bar', 'foo')).toEqual('ASC');
    });

    it('returns ASC when no current order dir is provided', () => {
      expect(determineOrderDir('foo', 'foo')).toEqual('ASC');
      expect(determineOrderDir('bar', 'bar')).toEqual('ASC');
    });

    it('returns DESC when current order field and selected field are equal and current order dir is ASC', () => {
      expect(determineOrderDir('foo', 'foo', 'ASC')).toEqual('DESC');
      expect(determineOrderDir('bar', 'bar', 'ASC')).toEqual('DESC');
    });

    it('returns undefined when current order field and selected field are equal and current order dir is DESC', () => {
      expect(determineOrderDir('foo', 'foo', 'DESC')).toBeUndefined();
      expect(determineOrderDir('bar', 'bar', 'DESC')).toBeUndefined();
    });
  });

  describe('fixLeafletIcons', () => {
    it('updates icons used by leaflet', () => {
      fixLeafletIcons();

      const { iconRetinaUrl, iconUrl, shadowUrl } = L.Icon.Default.prototype.options;

      expect(iconRetinaUrl).toEqual(marker2x);
      expect(iconUrl).toEqual(marker);
      expect(shadowUrl).toEqual(markerShadow);
    });
  });

  describe('rangeOf', () => {
    const func = (i) => `result_${i}`;
    const size = 5;

    it('builds a range of specified size invike provided function', () => {
      expect(rangeOf(size, func)).toEqual([
        'result_1',
        'result_2',
        'result_3',
        'result_4',
        'result_5',
      ]);
    });

    it('builds a range starting at provided pos', () => {
      const startAt = 3;

      expect(rangeOf(size, func, startAt)).toEqual([
        'result_3',
        'result_4',
        'result_5',
      ]);
    });
  });

  describe('roundTen', () => {
    it('rounds provided number to the next multiple of ten', () => {
      const expectationsPairs = [
        [ 10, 10 ],
        [ 12, 20 ],
        [ 158, 160 ],
        [ 5, 10 ],
        [ -42, -40 ],
      ];

      expect.assertions(expectationsPairs.length);

      expectationsPairs.forEach(([ number, expected ]) => {
        expect(roundTen(number)).toEqual(expected);
      });
    });
  });
});


1			import * as sinon from 'sinon';
2			import L from 'leaflet';
3			import marker2x from 'leaflet/dist/images/marker-icon-2x.png';
4			import marker from 'leaflet/dist/images/marker-icon.png';
5			import markerShadow from 'leaflet/dist/images/marker-shadow.png';
6			import {
7			stateFlagTimeout as stateFlagTimeoutFactory,
			0 ignored issues – show Unused Code introduced 2019-03-10 17:01 UTC by Report Bug Copy Issue Report The variable `stateFlagTimeout` seems to be never used. Consider removing it. Loading history...
8			determineOrderDir,
9			fixLeafletIcons,
10			rangeOf,
11			roundTen,
12			} from '../../src/utils/utils';
13
14			describe('utils', () => {
15			describe('stateFlagTimeout', () => {
16			it('sets state and initializes timeout with provided delay', () => {
17			const setTimeout = sinon.fake((callback) => callback());
18			const setState = sinon.spy();
19			const stateFlagTimeout = stateFlagTimeoutFactory(setTimeout);
20			const delay = 5000;
21			const expectedSetStateCalls = 2;
22
23			stateFlagTimeout(setState, 'foo', false, delay);
24
25			expect(setState.callCount).toEqual(expectedSetStateCalls);
26			expect(setState.getCall(0).args).toEqual([{ foo: false }]);
27			expect(setState.getCall(1).args).toEqual([{ foo: true }]);
28			expect(setTimeout.callCount).toEqual(1);
29			expect(setTimeout.getCall(0).args[1]).toEqual(delay);
30			});
31			});
32
33			describe('determineOrderDir', () => {
34			it('returns ASC when current order field and selected field are different', () => {
35			expect(determineOrderDir('foo', 'bar')).toEqual('ASC');
36			expect(determineOrderDir('bar', 'foo')).toEqual('ASC');
37			});
38
39			it('returns ASC when no current order dir is provided', () => {
40			expect(determineOrderDir('foo', 'foo')).toEqual('ASC');
41			expect(determineOrderDir('bar', 'bar')).toEqual('ASC');
42			});
43
44			it('returns DESC when current order field and selected field are equal and current order dir is ASC', () => {
45			expect(determineOrderDir('foo', 'foo', 'ASC')).toEqual('DESC');
46			expect(determineOrderDir('bar', 'bar', 'ASC')).toEqual('DESC');
47			});
48
49			it('returns undefined when current order field and selected field are equal and current order dir is DESC', () => {
50			expect(determineOrderDir('foo', 'foo', 'DESC')).toBeUndefined();
51			expect(determineOrderDir('bar', 'bar', 'DESC')).toBeUndefined();
52			});
53			});
54
55			describe('fixLeafletIcons', () => {
56			it('updates icons used by leaflet', () => {
57			fixLeafletIcons();
58
59			const { iconRetinaUrl, iconUrl, shadowUrl } = L.Icon.Default.prototype.options;
60
61			expect(iconRetinaUrl).toEqual(marker2x);
62			expect(iconUrl).toEqual(marker);
63			expect(shadowUrl).toEqual(markerShadow);
64			});
65			});
66
67			describe('rangeOf', () => {
68			const func = (i) => `result_${i}`;
69			const size = 5;
70
71			it('builds a range of specified size invike provided function', () => {
72			expect(rangeOf(size, func)).toEqual([
73			'result_1',
74			'result_2',
75			'result_3',
76			'result_4',
77			'result_5',
78			]);
79			});
80
81			it('builds a range starting at provided pos', () => {
82			const startAt = 3;
83
84			expect(rangeOf(size, func, startAt)).toEqual([
85			'result_3',
86			'result_4',
87			'result_5',
88			]);
89			});
90			});
91
92			describe('roundTen', () => {
93			it('rounds provided number to the next multiple of ten', () => {
94			const expectationsPairs = [
95			[ 10, 10 ],
96			[ 12, 20 ],
97			[ 158, 160 ],
98			[ 5, 10 ],
99			[ -42, -40 ],
100			];
101
102			expect.assertions(expectationsPairs.length);
			0 ignored issues – show Bug introduced 2019-03-10 17:01 UTC by Report Bug Copy Issue Report The variable `expect` seems to be never declared. If this is a global, consider adding a `/** global: expect */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
103			expectationsPairs.forEach(([ number, expected ]) => {
104			expect(roundTen(number)).toEqual(expected);
105			});
106			});
107			});
108			});
109

shlinkio / shlink-web-client

Pull Request — master (#124)

utils.test.js ➔ ... ➔ ??? A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like